From eb3ccfb404f8660c9a916423dfb5731bbdeac5a5 Mon Sep 17 00:00:00 2001
From: Benjamin Otte <otte@redhat.com>
Date: Wed, 14 Jun 2023 21:20:56 +0200
Subject: [PATCH] vulkan: Remove gsk_vulkan_image_new_for_framebuffer()

Use gsk_vulkan_image_new_for_offscreen() instead, it does the same thing
pretty much.
---
 gsk/vulkan/gskvulkanimage.c        | 20 --------------------
 gsk/vulkan/gskvulkanimageprivate.h |  3 ---
 gsk/vulkan/gskvulkanrenderer.c     |  6 +++---
 3 files changed, 3 insertions(+), 26 deletions(-)

diff --git a/gsk/vulkan/gskvulkanimage.c b/gsk/vulkan/gskvulkanimage.c
index 42bb3ff653..d289f7834f 100644
--- a/gsk/vulkan/gskvulkanimage.c
+++ b/gsk/vulkan/gskvulkanimage.c
@@ -744,26 +744,6 @@ gsk_vulkan_image_new_for_swapchain (GdkVulkanContext *context,
   return self;
 }
 
-GskVulkanImage *
-gsk_vulkan_image_new_for_framebuffer (GdkVulkanContext *context,
-                                      gsize             width,
-                                      gsize             height)
-{
-  GskVulkanImage *self;
-
-  self = gsk_vulkan_image_new (context,
-                               GDK_MEMORY_DEFAULT,
-                               width,
-                               height,
-                               VK_IMAGE_TILING_OPTIMAL,
-                               VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT,
-                               VK_IMAGE_LAYOUT_UNDEFINED,
-                               VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT,
-                               VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);
-
-  return self;
-}
-
 GskVulkanImage *
 gsk_vulkan_image_new_for_atlas (GdkVulkanContext *context,
                                 gsize             width,
diff --git a/gsk/vulkan/gskvulkanimageprivate.h b/gsk/vulkan/gskvulkanimageprivate.h
index 51aae186de..cb87e93bdb 100644
--- a/gsk/vulkan/gskvulkanimageprivate.h
+++ b/gsk/vulkan/gskvulkanimageprivate.h
@@ -40,9 +40,6 @@ void                    gsk_vulkan_image_upload_regions                 (GskVulk
                                                                          GskVulkanUploader      *uploader,
                                                                          guint                   num_regions,
                                                                          GskImageRegion         *regions);
-GskVulkanImage *        gsk_vulkan_image_new_for_framebuffer            (GdkVulkanContext       *context,
-                                                                         gsize                   width,
-                                                                         gsize                   height);
 GskVulkanImage *        gsk_vulkan_image_new_for_atlas                  (GdkVulkanContext       *context,
                                                                          gsize                   width,
                                                                          gsize                   height);
diff --git a/gsk/vulkan/gskvulkanrenderer.c b/gsk/vulkan/gskvulkanrenderer.c
index 0a495e8679..a163e25350 100644
--- a/gsk/vulkan/gskvulkanrenderer.c
+++ b/gsk/vulkan/gskvulkanrenderer.c
@@ -284,9 +284,9 @@ gsk_vulkan_renderer_render_texture (GskRenderer           *renderer,
                                          viewport->origin.y,
                                          ceil (viewport->size.width),
                                          ceil (viewport->size.height));
-  image = gsk_vulkan_image_new_for_framebuffer (self->vulkan,
-                                                rounded_viewport.size.width,
-                                                rounded_viewport.size.height);
+  image = gsk_vulkan_image_new_for_offscreen (self->vulkan,
+                                              rounded_viewport.size.width,
+                                              rounded_viewport.size.height);
 
   gsk_vulkan_render_reset (render, image, &rounded_viewport, NULL);
   gsk_vulkan_render_add_node (render, root);
-- 
2.30.2